Skip to content

The type and displayInformation is neglected creating a VerifiablePresentation#992

Merged
Milena-Czierlinski merged 3 commits intorelease/openid4vcfrom
fix-verifiable-presentation
Mar 12, 2026
Merged

The type and displayInformation is neglected creating a VerifiablePresentation#992
Milena-Czierlinski merged 3 commits intorelease/openid4vcfrom
fix-verifiable-presentation

Conversation

@Milena-Czierlinski
Copy link
Copy Markdown
Member

@Milena-Czierlinski Milena-Czierlinski commented Mar 12, 2026

Readiness checklist

  • I added/updated tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.
  • I self-reviewed the PR.

@Milena-Czierlinski Milena-Czierlinski added the bug Something isn't working label Mar 12, 2026
@Milena-Czierlinski Milena-Czierlinski marked this pull request as ready for review March 12, 2026 09:36
Copy link
Copy Markdown

@nicole-eb nicole-eb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 🥳

Copy link
Copy Markdown
Contributor

@Magnus-Kuhn Magnus-Kuhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course - the way I did it didn't work because the credential is a class instance 🤦

@Milena-Czierlinski Milena-Czierlinski merged commit 8a884c2 into release/openid4vc Mar 12, 2026
26 of 27 checks passed
@Milena-Czierlinski Milena-Czierlinski deleted the fix-verifiable-presentation branch March 12, 2026 10:14
Magnus-Kuhn pushed a commit that referenced this pull request Mar 27, 2026
…ePresentation (#992)

* chore: npm audit fix

* test: displayInformation is transferred in PresentationToken

* fix: explicitly hand over type and displayInformation when creating VerifiablePresentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants